[Bug 787985] New: webpenc: fix unmap video frame in failed case

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787985

            Bug ID: 787985
           Summary: webpenc: fix unmap video frame in failed case
    Classification: Platform
           Product: GStreamer
           Version: 1.13.x
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: p.srinivas at samsung.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 360192
  --> https://bugzilla.gnome.org/attachment.cgi?id=360192&action=edit
patch file attached

Hi ,
 In gst_webp_enc_handle_frame, missed Unmap video frame in failed case

 code:
 if (WebPEncode (&enc->webp_config, &enc->webp_picture)) {
    WebPPictureFree (&enc->webp_picture);

    out_buffer = gst_buffer_new_allocate (NULL, enc->webp_writer.size, NULL);
    if (!out_buffer) {
      GST_ERROR_OBJECT (enc, "Failed to create output buffer");
      return GST_FLOW_ERROR;
    }
    gst_buffer_fill (out_buffer, 0, enc->webp_writer.mem,
        enc->webp_writer.size);
    free (enc->webp_writer.mem);
  } else {
    GST_ERROR_OBJECT (enc, "Failed to encode WebPPicture");
    return GST_FLOW_ERROR;


  sol: gst_video_frame_unmap (&vframe); added 
  Patch attached. Please review and share feedback.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.