[Bug 788006] audiobasesink: Fix clock skew adjustments
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Sep 21 19:58:42 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=788006
--- Comment #4 from GstBlub <gstblub at gmail.com> ---
Unless there happen to be unit tests around this logic already, I don't think I
have the time to do this.
All I can say is that I believe the current logic is flawed in that it assumes
a linear drift, and because of that, once it exceeded the allowed drift in one
direction, it corrected by the whole drift tolerance value "back", placing the
new ideal center on the edge of the window on the other side. If the clock
then skewed some more, odds are it skewed outside of the window, triggering yet
another correction. This behavior required a skew tolerance to be set much
higher than needed.
Depending on the alignment threshold property value, this may also avoid an
alignment resync due to smaller corrections, which means most skew corrections
may now be much more subtle.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list