[Bug 784599] kmssink: support videooverlay interface

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Sep 21 20:45:14 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=784599

--- Comment #78 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 359676:
 --> (https://bugzilla.gnome.org/review?bug=784599&attachment=359676)

::: sys/kms/gstkmssink.c
@@ +153,3 @@
+
+    gst_pad_push_event (GST_BASE_SINK (self)->sinkpad,
+        gst_event_new_reconfigure ());

I didn't realize, but this code is not correct. expose should always do a
synchronous _show_frame(), even if the new render rectangle is not yet applied.
You have an old last buffer in hand anyway.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list