[Bug 788041] deinterlace: Fixed memory leak in error code path.

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Sep 22 11:00:00 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=788041

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #360249|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 360249:
 --> (https://bugzilla.gnome.org/review?bug=788041&attachment=360249)

Thanks for the patch, it's correct. But while we're at it, some other minor
cleanup can also be done:

::: gst/deinterlace/gstdeinterlace.c
@@ +2814,2 @@
     if (srccaps)
       gst_caps_unref (srccaps);

srccaps are always not NULL here and in the set_caps_failed case

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list