[Bug 788114] New: alsasink: Fix Memory leak in payload not succuss case

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Sep 25 05:21:04 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=788114

            Bug ID: 788114
           Summary: alsasink: Fix Memory leak in payload not succuss case
    Classification: Platform
           Product: GStreamer
           Version: 1.13.x
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: p.srinivas at samsung.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 360332
  --> https://bugzilla.gnome.org/attachment.cgi?id=360332&action=edit
patch file attached

Hi ,

  In gst_alsasink_payload , missed buffer unmap in payload failed case.
  code:
  out = gst_buffer_new_and_alloc (framesize);

    gst_buffer_map (buf, &iinfo, GST_MAP_READ);
    gst_buffer_map (out, &oinfo, GST_MAP_WRITE);

    if (!gst_audio_iec61937_payload (iinfo.data, iinfo.size,
            oinfo.data, oinfo.size, &sink->ringbuffer->spec, G_BIG_ENDIAN)) {
      gst_buffer_unref (out);
      return NULL;
    }

    gst_buffer_unmap (buf, &iinfo);
    gst_buffer_unmap (out, &oinfo);

   sol: gst_buffer_unmap added 
  Patch attached. Please review and share feedback.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list