[Bug 788152] plugin: API: GST_PLUGIN_DEPENDENCY_FLAG_PATHS_ARE_RELATIVE_TO_EXE

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788152

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #360377|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 360377:
 --> (https://bugzilla.gnome.org/review?bug=788152&attachment=360377)

Generally looks good to me, just some cosmetics.

::: gst/gst.c
@@ +363,3 @@
+find_executable_path (void)
+{
+}

Might want to do a GST_FIXME() here.

::: gst/gstplugin.c
@@ +1726,3 @@
+      if (paths_are_relative_to_exe && !g_path_is_absolute (path)) {
+        if (!_gst_executable_path) {
+          GST_LOG_OBJECT (plugin,

GST_FIXME

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.