[Bug 788243] New: nvbaseenc: fix unmap video frame in failed case

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788243

            Bug ID: 788243
           Summary: nvbaseenc: fix unmap video frame in failed case
    Classification: Platform
           Product: GStreamer
           Version: 1.13.x
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: p.srinivas at samsung.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 360537
  --> https://bugzilla.gnome.org/attachment.cgi?id=360537&action=edit
patch file attached

Hi ,

In gst_nv_base_enc_handle_frame(), unmap video frame is missed in error case.

code:

 flow = _acquire_input_buffer (nvenc, &input_buffer);
  if (flow != GST_FLOW_OK)
    return flow;
  if (input_buffer == NULL)
    return GST_FLOW_ERROR;


sol:

called goto out and goto error in failed case. This will unmap video frame .

 if (flow != GST_FLOW_OK)
    goto out;
  if (input_buffer == NULL)
    goto error;

Please review and share feedback.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.