[Bug 787560] audio: Add helper object for audio discontinuity detection

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787560

--- Comment #18 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 359718:
 --> (https://bugzilla.gnome.org/review?bug=787560&attachment=359718)

Looks good in general, I have couple of questions, nothing major really.

::: gst-libs/gst/audio/gstaudiostreamalign.c
@@ +26,3 @@
+#include "gstaudiostreamalign.h"
+
+G_DEFINE_BOXED_TYPE (GstAudioStreamAlign, gst_audio_stream_align,

I was wondering between GstAudioStreamAlignment vs GstAudioStreamAlign, we have
GstVidoAlginment, but GstAllocationParams.align. So I guess it makes it's
pretty equal, just mentionning, nothing to change.

@@ +29,3 @@
+    (GBoxedCopyFunc) gst_audio_stream_align_copy,
+    (GBoxedFreeFunc) gst_audio_stream_align_free);
+

Maybe a SECTION block to help document ?

@@ +72,3 @@
+  align = g_new0 (GstAudioStreamAlign, 1);
+  align->rate = rate;
+  align->alignment_threshold = 40 * GST_MSECOND;

Why isn't this parameters like the rate? They are configurable in the sink,
then the base class fixate the defaults no ? I also remember a recent thread
indicating a possible bug that after fix allow reducing greatly the thresholds,
so maybe we shoulnd't scatter the defaults ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.