[Bug 787560] audio: Add helper object for audio discontinuity detection

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787560

--- Comment #24 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Nicolas Dufresne (stormer) from comment #18)

> @@ +26,3 @@
> +#include "gstaudiostreamalign.h"
> +
> +G_DEFINE_BOXED_TYPE (GstAudioStreamAlign, gst_audio_stream_align,
> 
> I was wondering between GstAudioStreamAlignment vs GstAudioStreamAlign, we
> have GstVidoAlginment, but GstAllocationParams.align. So I guess it makes
> it's pretty equal, just mentionning, nothing to change.

Align would be a verb, this thing is doing something (-> verb) while
GstVideoAlignment is just data (-> noun). GstAllocationParams.align is an
"order", please align that much (-> verb). IMHO this all makes sense as is :)

> @@ +29,3 @@
> +    (GBoxedCopyFunc) gst_audio_stream_align_copy,
> +    (GBoxedFreeFunc) gst_audio_stream_align_free);
> +
> 
> Maybe a SECTION block to help document ?

Done

> @@ +72,3 @@
> +  align = g_new0 (GstAudioStreamAlign, 1);
> +  align->rate = rate;
> +  align->alignment_threshold = 40 * GST_MSECOND;
> 
> Why isn't this parameters like the rate? They are configurable in the sink,
> then the base class fixate the defaults no ? I also remember a recent thread
> indicating a possible bug that after fix allow reducing greatly the
> thresholds, so maybe we shoulnd't scatter the defaults ?

Added to the constructor now, good idea :)


(In reply to Nicolas Dufresne (stormer) from comment #20)
> Review of attachment 359721 [details] [review]:
> 
> Optional comment for this one.
> 
> ::: gst-libs/gst/audio/gstaudiostreamalign.h
> @@ -31,2 @@
>  GST_EXPORT
> -GType                   gst_audio_stream_align_get_type               
> (void);
> 
> the reformatting is nice, by quite unrelated. It's nitpicking, bug maybe we
> could have slip it up ?

The reformatting is only needed because of this new commit :) It requires
horizontal indentation to be increased.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.