[Bug 727802] md5 checksum is missing from flac files encoded with encodebin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=727802

Phillip Wood <phillip.wood at dunelm.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phillip.wood at dunelm.org.uk

--- Comment #28 from Phillip Wood <phillip.wood at dunelm.org.uk> ---
Unfortunately while this fixes the MD5 metadata it breaks the vorbis comments.
There have been some reports that sound-juicer is extracting flac flies with
corrupted metadata recently[1,2], reverting the changes to gstflacparse.[ch] in
commit adeee44b fixes the problem with the vorbis tags. Here is the output of
metaflac --list showing the first and third metadata data blocks with
gst-plugins-good 1.12.3 and the same version with the changes to
gstflacparse.[ch] in commit adeee44b reverted

v 1.12.3
METADATA block #0
  type: 0 (STREAMINFO)
  is last: false
  length: 34
  minimum blocksize: 4608 samples
  maximum blocksize: 4608 samples
  minimum framesize: 798 bytes
  maximum framesize: 10089 bytes
  sample_rate: 44100 Hz
  channels: 2
  bits-per-sample: 16
  total samples: 3705576
  MD5 signature: 3e664118223eadd47b5830ccedfa16cc
METADATA block #3
  type: 4 (VORBIS_COMMENT)
  is last: true
  length: 321
  vendor string: GStreamer encoded vorbiscomment
  comments: 7
    comment[0]: TITLE=My Lady Hunnsdon's Puffe (P 54)
    comment[1]: ARTIST=Paul O'Dette
    comment[2]: TRACKNUMBER=1
    comment[3]: TRACKTOTAL=23
    comment[4]: ALBUM=My Favorite D
    comment[5]: 
    comment[6]: 

v 1.12.3 with adeee44b reverted
With this change reverted
METADATA block #0
  type: 0 (STREAMINFO)
  is last: false
  length: 34
  minimum blocksize: 4608 samples
  maximum blocksize: 4608 samples
  minimum framesize: 0 bytes
  maximum framesize: 0 bytes
  sample_rate: 44100 Hz
  channels: 2
  bits-per-sample: 16
  total samples: 3705576
  MD5 signature: 00000000000000000000000000000000
METADATA block #3
  type: 4 (VORBIS_COMMENT)
  is last: true
  length: 321
  vendor string: GStreamer encoded vorbiscomment
  comments: 11
    comment[0]: TITLE=My Lady Hunnsdon's Puffe (P 54)
    comment[1]: ARTIST=Paul O'Dette
    comment[2]: TRACKNUMBER=1
    comment[3]: TRACKTOTAL=23
    comment[4]: ALBUM=My Favorite Dowland
    comment[5]: COMPOSER=John Dowland
    comment[6]: ALBUMARTIST=Paul O'Dette
    comment[7]: GENRE=Classical
    comment[8]: DATE=2014
    comment[9]: DISCID=4711a817
    comment[10]: MUSICBRAINZ_DISCID=Oz7pe6Alnaq6h3zQsog7caD5tMM-


[1] https://bugzilla.gnome.org/show_bug.cgi?id=784092
[2] https://bugzilla.gnome.org/show_bug.cgi?id=785558

-- 
You are receiving this mail because:
You are the QA Contact for the bug.