[Bug 794911] Implement support for ULP Forward Error Correction

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794911

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370453|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 370453:
 --> (https://bugzilla.gnome.org/review?bug=794911&attachment=370453)

Are we always sending FEC now if requested on the media? Or only if the client
(for PLAY) requests that from the SDP?

::: gst/rtsp-server/rtsp-media.c
@@ +1519,3 @@
+          i, &storage);
+      if (storage)
+        g_object_set (storage, "size-time", (media->priv->latency + 50) *
GST_MSECOND, NULL);

Should this 50ms be configurable?

@@ +3132,3 @@
+new_storage_cb (GstElement * rtpbin, GObject * storage, guint sessid,
GstRTSPMedia * media)
+{
+  g_object_set (storage, "size-time", (media->priv->latency + 50) *
GST_MSECOND, NULL);

And this 50ms?

::: gst/rtsp-server/rtsp-stream.c
@@ +5019,3 @@
+
+
+/**

Double new-line above

::: gst/rtsp-server/rtsp-stream.h
@@ +310,3 @@
+/* ULP Forward Error Correction (RFC 5109) */
+GST_RTSP_SERVER_API
+gboolean           gst_rtsp_stream_get_ulpfec_enabled (GstRTSPStream *stream);

I wonder if some more generic API could be added here, similar to what is in
rtpbin. So that we won't have to add yet another set of functions for flexfec
later.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.