[Bug 794840] display: drm: Remove PCI bus assumption when looking up the DRM device

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794840

--- Comment #4 from Paul Kocialkowski <paul.kocialkowski at bootlin.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #2)
> Review of attachment 370340 [details] [review]:
> 
> Thanks for the patch.
> 
> Just a couple nitpicks.
> 
> ::: gst-libs/gst/vaapi/gstvaapidisplay_drm.c
> @@ +118,3 @@
>        }
>  
> +
> 
> nitpick: I guess this extra line is not part of the patch

Good catch, I'll remove it in the next version.

> @@ +210,1 @@
>  
> 
> Another nitpick: this block could be more compact if
> 
> if (strncmp (busid, "pci:", 4) == 0)
>   busid += 4;
> else if (strncmp (busid, "platform:", 9) == 0)
>   busid += 9;
> else
>   goto end;
> 
> busid_length = strlen (busid)
> 
> But if you add a static structure with a loop, would be much more neat :)

I'll probably go with a structure/loop approach so that new subsystems can be
added more easily, thanks for the suggestion!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.