[Bug 794909] ulpfecdec: output perfect seqnums

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794909

Mikhail Fludkov <fludkov.me at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fludkov.me at gmail.com

--- Comment #3 from Mikhail Fludkov <fludkov.me at gmail.com> ---
Given how weird ULPFEC beast is. The better approach is for the depayloader (or
decoder) to take care of that. What you are trying to achieve in this patch
should be done codec by codec basis. There is no generic solution to that. For
example, VP8 & VP9 should be able to figure out if the discontinuity happened
in the middle of the frame or between the frames. If it happened between the
frames picture_id should be used to understand if the lost packet was a media
packet or FEC (see
https://github.com/pexip/gst-plugins-good/commit/3c67c9528e9f4cd87708abefd9e967fbcc4a4e08).

The patch introduces more harm than good IMO. If you really wanna go for it,
make this behavior disabled by default and configured by a property. 

BTW. It hides discontinuity in sequence numbers by changing sequnce number
domain of the media stream, but it does not do the same for so for the
GstRTPPacketLost events.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.