[Bug 794901] Closed Caption and Ancillary data support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794901

--- Comment #7 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 370441:
 --> (https://bugzilla.gnome.org/review?bug=794901&attachment=370441)

::: gst-libs/gst/video/video-anc.c
@@ +205,3 @@
+ * gst_video_vbi_parser_get_ancillary:
+ * @parser: a #GstVideoVBIParser
+ * @anc: (out): a #GstVideoAncillary to start the eventual ancillary data

Did you have anything in mind ?

@@ +411,3 @@
+      break;
+    default:
+      GST_ERROR ("UNSUPPORTED FORMAT !");

Technically this shouldn't happen (since we check the format when creating the
parser), but I'll add one.

@@ +461,3 @@
+  GstVideoCaptionMeta *emeta = (GstVideoCaptionMeta *) meta;
+
+  emeta->caption_type = GST_VIDEO_CAPTION_TYPE_UNKNOWN;

ack

@@ +471,3 @@
+  GstVideoCaptionMeta *emeta = (GstVideoCaptionMeta *) meta;
+
+  g_free (emeta->data);

ack

::: gst-libs/gst/video/video-anc.h
@@ +49,3 @@
+  guint8 SDID_block_number;
+  guint8 data_count;
+  guint8 *data;

Ack, and avoid the potentially confusing alloc/copy.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.