[Bug 773863] decklinkvideosrc: add VANC parsing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773863

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370484|none                        |reviewed
             status|                            |

--- Comment #41 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 370484:
 --> (https://bugzilla.gnome.org/review?bug=773863&attachment=370484)

::: sys/decklink/gstdecklink.cpp
@@ +236,3 @@
+#define PAL 12, 11, true, "bt601", FALSE
+#define HD 1, 1, true, "bt709", TRUE
+#define UHD 1, 1, true, "bt2020", TRUE

For NTSC and PAL there's nothing?

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +790,3 @@
+  GstVideoFormat videoformat;
+  // FIXME : Move to a central location
+  GstVideoVBIParser *parser = NULL;

Yes storing that in the instance would seem better

@@ +849,3 @@
+  after = gst_util_get_timestamp ();
+  GST_LOG ("Processing ANC took %" GST_TIME_FORMAT,
+      GST_TIME_ARGS (after - before));

Should this stay or is it debug code?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.