[Bug 794958] rtxsend: fix wrong memory layout assumption

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794958

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370509|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 370509:
 --> (https://bugzilla.gnome.org/review?bug=794958&attachment=370509)

::: gst/rtpmanager/gstrtprtxsend.c
@@ -401,3 @@
   /* copy extension if any */
   if (rtp.size[1]) {
-    mem = gst_memory_copy (rtp.map[1].memory, 0, rtp.size[1]);

memory is NULL in that case or how does it work? But the data and size pointers
are all correctly set?

But in the udpsrc case for example we should be able to copy the memory
nonetheless and use a different offset instead of completely copying. Not sure
if that makes much of a difference though and it would complicate the code
quite a bit, and still not cover all potential cases.

So merge as-is unless you see a way of doing this nicer :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.