[Bug 794773] buffer: gst_buffer_copy_into should not copy parent buffer metas when doing a deep copy

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794773

--- Comment #5 from Philipp Zabel <p.zabel at pengutronix.de> ---
I was mistaken, "memory" tagged metas are dropped if

      ((region || !(flags & GST_BUFFER_COPY_MEMORY)
              || (flags & GST_BUFFER_COPY_MERGE))
          && gst_meta_api_type_has_tag (info->api, _gst_meta_tag_memory))

but not on deep copies, so it seems we want something different here.

If I understand correctly, "memory" is for metas that describe or reference
memory layout ("This metadata stays relevant as long as memory layout is
unchanged"), but here we have a meta that describes a reference to a parent
buffer that our buffer is derived from ("This metadata stays relevant until a
deep copy is made?").

Would just adding a "parent" meta tag be appropriate?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.