[Bug 794998] omxvideoenc: restore OMX default target-bitrate if requested by user

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794998

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370551|none                        |reviewed
             status|                            |

--- Comment #6 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 370551:
 --> (https://bugzilla.gnome.org/review?bug=794998&attachment=370551)

::: omx/gstomx.h
@@ +122,3 @@
+ * If set on a default_* variable means that the default values hasn't been
+ * retrieved from OMX yet. */
+#define GST_OMX_PROP_OMX_DEFAULT (0xffffffff)

Is this from the OMX spec? or is this only a local thing? Should't it be
G_MAXUINT32 ?

::: omx/gstomxvideoenc.c
@@ +766,3 @@
+    if (self->default_target_bitrate == GST_OMX_PROP_OMX_DEFAULT)
+      /* Save the actual OMX default so we can restore it if needed */
+      self->default_target_bitrate = bitrate_param.eControlRate;

Can this default ever change if other controls are modified? Or is it set for
the lifetime of the component even if stopped and restarted?

@@ +773,3 @@
       bitrate_param.nTargetBitrate = self->target_bitrate;
+    else
+      bitrate_param.nTargetBitrate = self->default_target_bitrate;

read from eControlRate but set to nTargetBitrate, is that voluntary?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.