[Bug 794717] Debug levels applied in wrong order

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794717

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
commit 6436437d836badb1f01f71cf039fa65e4a3a2023 (HEAD -> master, origin/master,
origin/HEAD)
Author: Jan Alexander Steffens (heftig) <jan.steffens at gmail.com>
Date:   Tue Mar 27 10:25:46 2018 +0200

    gstinfo: fix debug levels being applied in the wrong order

    Remove unneeded reapplication of patterns. Besides being
    superfluous (gst_debug_reset_threshold already applies
    patterns) it was also wrong and didn't stop checking patterns
    after the first match (broken in 67e9d139).

    Also fix up unit test which checked for the wrong order.

    https://bugzilla.gnome.org/show_bug.cgi?id=794717

commit c4ff06986442fe50f424161220ccb31db758b797
Author: Jan Alexander Steffens (heftig) <jan.steffens at gmail.com>
Date:   Tue Mar 27 10:15:46 2018 +0200

    gstinfo: Simplify gst_debug_reset_threshold() implementation

    Replace the while+goto with a for+break and check walk to determine
    whether we had a match. Move up the unlock to keep the locked section as
    small as possible.

    https://bugzilla.gnome.org/show_bug.cgi?id=794717

commit b12df466f2075bb85b684cd8872127e4022e58ab
Author: Jan Alexander Steffens (heftig) <jan.steffens at gmail.com>
Date:   Tue Mar 27 10:14:27 2018 +0200

    gstinfo: Reduce code duplication around level pattern matching

    Move the match, logging and set_threshold to a new function.

    The log levels are different, so choose the higher one (LOG). Having two
    equivalent messages at two different levels seems like a bad idea
    anyway.

    https://bugzilla.gnome.org/show_bug.cgi?id=794717

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.