[Bug 794998] omxvideoenc: restore OMX default target-bitrate if requested by user

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 6 13:12:56 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=794998

Guillaume Desmottes <gdesmott at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370551|reviewed                    |none
             status|                            |
 Attachment #370551|0                           |1
        is obsolete|                            |

--- Comment #8 from Guillaume Desmottes <gdesmott at gnome.org> ---
Created attachment 370578
  --> https://bugzilla.gnome.org/attachment.cgi?id=370578&action=edit
omxvideoenc: restore OMX default target-bitrate if requested by user

0xffffffff is the magic number in gst-omx meaning 'the default value
defined in OMX'. This works fine with OMX parameters which are only set
once when starting the component but not with configs which can be
changed while PLAYING.
Save the actual OMX default bitrate so we can restore it later if user
sets back 0xffffffff on the property.

Added GST_OMX_PROP_OMX_DEFAULT so we stop hardcoding magic numbers
everywhere.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list