[Bug 795032] h265parse: Make caps writable before modifying them

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Apr 8 05:29:34 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795032

--- Comment #5 from Seungha Yang <pudding8757 at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #4)
> Review of attachment 370589 [details] [review]:
> 
> ::: gst/videoparsers/gsth265parse.c
> @@ +2270,2 @@
>    /* Try if we can put the downstream caps first */
> +  pcopy = gst_caps_copy (peercaps);
> 
> There was I guess a reason to no use gst_caps_make_writable() ?

Both gst_caps_make_writable() and gst_caps_copy() work well, but I just
followed the h264parse version patch for consistency. 

https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=c0226e08e324fb416c2bb8eb95bb690152397f84

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list