[Bug 760834] orc Illegal Instructions on mips32el

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760834

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370593|none                        |needs-work
             status|                            |

--- Comment #8 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 370593
  --> https://bugzilla.gnome.org/attachment.cgi?id=370593
patch1

Thanks for the patches!

This one is generally fine, just some small nitpicks:

 - unistd.h include should be guarded with HAVE_UNISTD_H

 - I think get_file() should be called get_proc_cpuinfo() as before, since it
only reads at most 4095 bytes, so let's leave it specific until someone needs a
more general get_file() ?

 - should we only build the get_file/get_proc_cpuinfo function if actually
needed? (HAVE_ARM or HAVE_MIPSEL) - thinking about open/read on windows build.

I can make these changes as well if you agree.

(There's some ugliness about having internal helper API in the public
orcutils.h header, but will fix that independently.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.