[Bug 794840] display: drm: Remove PCI bus assumption when looking up the DRM device

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Apr 10 08:18:19 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=794840

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370599|none                        |reviewed
             status|                            |

--- Comment #9 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 370599:
 --> (https://bugzilla.gnome.org/review?bug=794840&attachment=370599)

::: gst-libs/gst/vaapi/gstvaapidisplay_drm.c
@@ +210,3 @@
+
+    if (strncmp (busid, allowed_subsystems[i], busid_length) == 0) {
+      busid += busid_length;

Aren't you forgetting to consider the ':' in the busid??

then it would be

/* add the trailing ':' char */
busid += busid_length + 1;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list