[Bug 792189] srt: add recipe

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Apr 10 16:45:11 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=792189

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370726|none                        |needs-work
             status|                            |

--- Comment #25 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 370726:
 --> (https://bugzilla.gnome.org/review?bug=792189&attachment=370726)

::: recipes/srt/0002-CMakeLists.txt-let-cmake-find-pthread.patch
@@ +2,3 @@
+From: Justin Kim <justin.kim at collabora.com>
+Date: Tue, 10 Apr 2018 11:57:59 +0900
+Subject: [PATCH] CMakeLists.txt: let cmake find pthread

Please add upstream PR or Issues link for later tracking.

@@ +42,3 @@
++set (THREADS_PREFER_PTHREAD_FLAG ON)
++find_package (Threads REQUIRED)
++set (SRT_LIBS_PRIVATE ${SRT_LIBS_PRIVATE} ${CMAKE_THREAD_LIBS_INIT})

That's massively simpler, and leave it to cmake to handle. Did you check if
this was added in a specific cmake version, and if we need to bump the
requirement ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list