[Bug 795145] appsink: Reuse sample object in pull_sample if possible

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795145

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370760|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 370760:
 --> (https://bugzilla.gnome.org/review?bug=795145&attachment=370760)

::: gst-libs/gst/app/gstappsink.c
@@ +824,3 @@
+          }
+          priv->sample =
+              gst_sample_new (NULL, priv->last_caps, &priv->last_segment,
NULL);

See my comment on the other bug, we could easily also update the segment, caps,
etc.

While this does not make much of a difference, it would make the code here more
consistent and does not really complicate anything... while it makes the
GstSample API more consistent (why would you be able to only change the buffer
but not e.g. the segment?)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.