[Bug 795156] gstqueuearray: make find() return a 0-based index

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Apr 11 15:57:34 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795156

--- Comment #3 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Tim-Philipp Müller from comment #2)
> Comment on attachment 370791 [details] [review]
> gstqueuearray: make find() return a 0-based index
> 
> I would like to see a small unit test addition for this as well please,
> since it's currently not tested.

There is a test that uses find() and drop_element(), test_array_drop2, I
figured this was sufficient?

> 
> The commit message should also mention why/that this change in
> interpretation of the index argument to _drop_*() is not a
> backwards-incompatible change (because it could only be used with return
> values from _find anyway).

sure, I'll update that

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list