[Bug 795145] appsink: Reuse sample object in pull_sample if possible

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795145

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370816|none                        |reviewed
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 370816:
 --> (https://bugzilla.gnome.org/review?bug=795145&attachment=370816)

::: gst-libs/gst/app/gstappsink.c
@@ +812,3 @@
           GST_DEBUG_OBJECT (appsink, "activating caps %" GST_PTR_FORMAT,
caps);
           gst_caps_replace (&priv->last_caps, caps);
+          gst_sample_set_caps (priv->sample, priv->last_caps);

Why would the sample be writable here and below?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.