[Bug 795173] kms: kmsbufferpool won't return false, when the input size won't apply to it

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795173

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370897|none                        |needs-work
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 370897:
 --> (https://bugzilla.gnome.org/review?bug=795173&attachment=370897)

- We don't use Signed-off-by in GStreamer commits
- I'm surprised this patch works for you, my impression is that the ksmsink
code need to adapt to a larger buffer being allocated here.

::: sys/kms/gstkmsallocator.c
@@ +188,3 @@
+
+  h = gst_drm_height_from_drm (fmt, GST_VIDEO_INFO_HEIGHT (vinfo));
+  height = vinfo->size / (arg.bpp / 8) / arg.width;

This is not valid for all the formats + this code should in the helper
gst_drm_height_from_drm(), it was factored out to keep this part readable, now
it's not.

@@ +214,3 @@
+      offs = GST_VIDEO_INFO_PLANE_OFFSET (vinfo, i);
+    else
+      GST_VIDEO_INFO_PLANE_OFFSET (vinfo, i) = offs;

This is hard to understand.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.