[Bug 795284] pcapparse: give error on fragmented IP packets

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795284

--- Comment #2 from Antonio Ospite <ao2 at ao2.it> ---
Created attachment 370970
  --> https://bugzilla.gnome.org/attachment.cgi?id=370970&action=edit
pcapparse: bail out in case of fragmented packets

pcapparse cannot parse fragmented IP packets correctly, in particular it
will get confused when trying to parsing fragments as standalone frames
in two ways:

  1. the first fragment will have the packet length greater than the
     frame size and will always be discarded;

  2. fragments with non-zero offsets will be interpreted as full packets
     and the first part of their raw payload data will be parsed as the
     transport protocol header, resulting in bogus values for addresses
     and ports, thus evading the properties filtering on those values.

This can make it difficult for users to see why the data does not get
downstream.

So be more explicit and just bail out when fragmented packets are
encountered.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.