[Bug 795195] gst_vaapi_texture_glx_put_surface_unlocked is blocked 75-80% of the time

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795195

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370982|none                        |reviewed
             status|                            |

--- Comment #7 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 370982:
 --> (https://bugzilla.gnome.org/review?bug=795195&attachment=370982)

Thanks for the patch Daniel.

::: gst-libs/gst/vaapi/gstvaapitexture_glx.c
@@ +362,3 @@

+  /* Ensure vaPutSurface has really finished populating the pixmap */
+  glXWaitX ();

A couple comments:

1. This patch is focused only on Intel driver, where vaSyncSurfce boils down to
DRM_IOCTL_I915_GEM_SET_DOMAIN ioctl (there are many comments in the intertubes
complaining about the latency of this ioctl)

2. We need to test this patch on gallium driver, particularly in radeon, when
decoding H.264, since it is where vaSyncSurface also flushes the pending
operations.

3. Perhaps this is not the correct approach to this bug, perhaps the bug is in
vaapi-intel-driver or even in the kernel. Thus, we would be hiding the bug

4. This patch replacing vaSyncSurface with glXWaitX looks to me similar like
adding a sleep in the code :D in order to avoid a race condition.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.