[Bug 789316] Add Meson support in cerbero

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789316

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370594|none                        |needs-work
             status|                            |

--- Comment #95 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Review of attachment 370594:
 --> (https://bugzilla.gnome.org/review?bug=789316&attachment=370594)

::: cerbero/build/build.py
@@ +399,3 @@
+            --default-library=%(default-library)s --buildtype=%(buildtype)s \
+            --backend=%(backend)s ..'
+    default_library = 'shared'

Do we want to change this? This made sense when we had separate recipes for
static and shared, and this value would be overriden in the static recipes.

@@ +425,3 @@
+        # Find Meson
+        if not self.meson_sh:
+            self.meson_sh = self.config.python_exe + ' ' +
shell.which('meson')

I originally used shell.which('meson') here because meson.py was installed into
the system prefix. But since it's in the build tools prefix, we know exactly
where it is. We should use that path directly.

This also means we don't need find_build_tools(), and we can hard-code paths to
both meson and ninja in the class variables.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.