[Bug 789316] Add Meson support in cerbero

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789316

--- Comment #98 from Xavier Claessens <xclaesse at gmail.com> ---
(In reply to Nirbheek Chauhan from comment #95)
> Review of attachment 370594 [details] [review]:
> 
> ::: cerbero/build/build.py
> @@ +399,3 @@
> +            --default-library=%(default-library)s --buildtype=%(buildtype)s
> \
> +            --backend=%(backend)s ..'
> +    default_library = 'shared'
> 
> Do we want to change this? This made sense when we had separate recipes for
> static and shared, and this value would be overriden in the static recipes.

Note we still have glib-networking-static but that's going away when we update
to latest glib, I made the patch upstream to build static gio modules. I guess
we should set default_library='both' as soon as meson 0.46 gets released. But
we cannot always build static, for example glib cannot do static for windows
atm. So I think we still need to be able to override default_library from
recipes.

> @@ +425,3 @@
> +        # Find Meson
> +        if not self.meson_sh:
> +            self.meson_sh = self.config.python_exe + ' ' +
> shell.which('meson')
> 
> I originally used shell.which('meson') here because meson.py was installed
> into the system prefix. But since it's in the build tools prefix, we know
> exactly where it is. We should use that path directly.
> 
> This also means we don't need find_build_tools(), and we can hard-code paths
> to both meson and ninja in the class variables.

Good point, I'm happy to be able to remove that hack, I'll update patch in a
bit.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.