[Bug 795330] pad: Handle changing sticky events in pad probes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795330

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371042|none                        |accepted-commit_now
             status|                            |

--- Comment #4 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 371042:
 --> (https://bugzilla.gnome.org/review?bug=795330&attachment=371042)

The new behaviour makes sense to me, assuming you ran the test suite with
valgrind I'd say go ahead apart from that one remark :)

::: gst/gstpad.c
@@ +3811,2 @@
 static gboolean
+cleanup_event (GstPad * pad, PadEvent * ev, gint64 * prev_offset)

That name is a bit non-descriptive, how about "reschedule_event" maybe ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.