[Bug 795159] Various patches on ssrcdemux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795159

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370796|none                        |needs-work
             status|                            |

--- Comment #4 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 370796:
 --> (https://bugzilla.gnome.org/review?bug=795159&attachment=370796)

::: gst/rtpmanager/gstrtpssrcdemux.c
@@ +284,3 @@
   }
+  // We create 2 src pads per ssrc (RTP & RTCP). Checking if we are allowed
+  // to create 2 more pads

Use /* */ style comments please

@@ +285,3 @@
+  // We create 2 src pads per ssrc (RTP & RTCP). Checking if we are allowed
+  // to create 2 more pads
+  num_streams = (GST_ELEMENT_CAST (demux)->numsrcpads) >> 1;

Why ">>1" ? Do you want to do / 2 really ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.