[Bug 795159] Various patches on ssrcdemux

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Apr 17 15:54:47 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795159

--- Comment #8 from Håvard Graff (hgr) <havard.graff at gmail.com> ---
(In reply to Olivier Crête from comment #4)
> Review of attachment 370796 [details] [review]:
> 
> ::: gst/rtpmanager/gstrtpssrcdemux.c
> @@ +284,3 @@
>    }
> +  // We create 2 src pads per ssrc (RTP & RTCP). Checking if we are allowed
> +  // to create 2 more pads
> 
> Use /* */ style comments please
> 
> @@ +285,3 @@
> +  // We create 2 src pads per ssrc (RTP & RTCP). Checking if we are allowed
> +  // to create 2 more pads
> +  num_streams = (GST_ELEMENT_CAST (demux)->numsrcpads) >> 1;
> 
> Why ">>1" ? Do you want to do / 2 really ?

Just that we get 2 pads for each stream, so this is a simple way of counting
the number of streams I guess?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list