[Bug 795160] Various patches on ptdemux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795160

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370801|none                        |needs-work
             status|                            |

--- Comment #3 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 370801:
 --> (https://bugzilla.gnome.org/review?bug=795160&attachment=370801)

Just one little stylistic detail, otherwise it looks fine.

::: gst/rtpmanager/gstrtpptdemux.c
@@ +343,3 @@
+  } else if (sink_caps) {
+    have_ssrc = gst_structure_get_uint (
+        gst_caps_get_structure (sink_caps, 0), "ssrc", &ssrc);

Can you get the structure on line, then do the get_uint on a separate one, this
is more the style

GstStructure *s = gst_caps_get_structure (sink_caps, 0);
have_ssrc = gst_structure_get_uint (s, "ssrc", &ssrc);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.