[Bug 795162] Various patches on rtpmux

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Apr 17 16:02:31 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795162

Olivier CrĂȘte <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370805|none                        |reviewed
             status|                            |

--- Comment #7 from Olivier CrĂȘte <olivier.crete at ocrete.ca> ---
Review of attachment 370805:
 --> (https://bugzilla.gnome.org/review?bug=795162&attachment=370805)

That sounds like a lot of INFO instead of DEBUG?

::: gst/rtpmanager/gstrtpmux.c
@@ +231,2 @@
           new_ssrc = rtp_mux->current_ssrc;
+          GST_INFO_OBJECT (rtp_mux, "Chose new ssrc %x", new_ssrc);

Maybe "New ssrc chosen after collision: %x"

@@ +878,3 @@
       rtp_mux->current_ssrc = rtp_mux->ssrc;
       rtp_mux->have_ssrc = TRUE;
+      GST_INFO_OBJECT (rtp_mux, "ssrc set to %x", rtp_mux->ssrc);

Maybe add that this is a property "SSRC property set to %x" ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list