[Bug 795366] debugutils: Add a testsrc element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795366

--- Comment #5 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 371129:
 --> (https://bugzilla.gnome.org/review?bug=795366&attachment=371129)

This looks generally useful, had a few remarks though :)

Also, I guess you could just add that to the autotools build, shouldn't be too
annoyying :)

::: gst/debugutils/gsttestsrc.c
@@ +30,3 @@
+ *
+ * This element also provides GstStream and GstStreamCollection and
+ * thus the element is usefull for testing the new playbin3 infrastructure.

useful*

@@ +60,3 @@
+
+  gchar *uri;
+  gboolean is_live;

Not used

@@ +73,3 @@
+};
+
+#define DEFAULT_LIVE FALSE

Not used

@@ +85,3 @@
+gst_test_src_uri_handler_get_protocols (GType type)
+{
+  static const gchar *protocols[] = { "test", NULL };

we might want a more specific protocol here, eg "testbin", what do you think ?

@@ +94,3 @@
+{
+  GstTestSrc *self = GST_TEST_SRC (handler);
+  gcha uri;

probably doesn't compile ;)

@@ +143,3 @@
+      if (data->collection) {
+        GstStreamCollection *collection = data->collection;
+        data->collection = NULL;

aren't you leaking data->collection here?

@@ +307,3 @@
+    G_IMPLEMENT_INTERFACE (GST_TYPE_URI_HANDLER,
gst_test_src_uri_handler_init))
+
+     static void

indent fail :)

@@ +358,3 @@
+  GstStateChangeReturn result = GST_STATE_CHANGE_FAILURE;
+
+  switch (transition) {

This whole switch case doesn't seem very useful :P

@@ +406,3 @@
+  gobject_class->set_property = gst_test_src_set_property;
+
+    /**

bad indent?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.