[Bug 795366] debugutils: Add a testsrc element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795366

--- Comment #7 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Mathieu Duponchelle from comment #5)
> Review of attachment 371129 [details] [review]:
> 
> This looks generally useful, had a few remarks though :)
> 
> Also, I guess you could just add that to the autotools build, shouldn't be
> too annoyying :)

Erg, autotools yes :P

> ::: gst/debugutils/gsttestsrc.c
> @@ +30,3 @@
> + *
> + * This element also provides GstStream and GstStreamCollection and
> + * thus the element is usefull for testing the new playbin3 infrastructure.
> 
> useful*

Done

> @@ +60,3 @@
> +
> +  gchar *uri;
> +  gboolean is_live;
> 
> Not used

FIXED.

> @@ +73,3 @@
> +};
> +
> +#define DEFAULT_LIVE FALSE
> 
> Not used

Done. 

> @@ +85,3 @@
> +gst_test_src_uri_handler_get_protocols (GType type)
> +{
> +  static const gchar *protocols[] = { "test", NULL };
> 
> we might want a more specific protocol here, eg "testbin", what do you think
> ?

Not sure, `testsrc` maybe? As you wish tbh :-)

> 
> @@ +143,3 @@
> +      if (data->collection) {
> +        GstStreamCollection *collection = data->collection;
> +        data->collection = NULL;
> 
> aren't you leaking data->collection here?

Nop, gst_event_new_stream_collection  is transfer-full

> @@ +307,3 @@
> +    G_IMPLEMENT_INTERFACE (GST_TYPE_URI_HANDLER,
> gst_test_src_uri_handler_init))
> +
> +     static void
> 
> indent fail :)

INDENT-OFF on :-)

> @@ +358,3 @@
> +  GstStateChangeReturn result = GST_STATE_CHANGE_FAILURE;
> +
> +  switch (transition) {
> 
> This whole switch case doesn't seem very useful :P

Removed.

> @@ +406,3 @@
> +  gobject_class->set_property = gst_test_src_set_property;
> +
> +    /**
> 
> bad indent?

Not sure what gst-indent did.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.