[Bug 795021] Reduce amount of memory allocations when payloading fixed-size audio buffers

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Apr 19 16:49:06 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795021

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370570|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 370570:
 --> (https://bugzilla.gnome.org/review?bug=795021&attachment=370570)

::: gst-libs/gst/audio/gstaudioencoder.c
@@ +2790,3 @@
+
+    config = gst_buffer_pool_get_config (pool);
+    gst_buffer_pool_config_get_params (config, NULL,
&enc->priv->ctx.pool_size,

This should set the size. So we should probably have a property on the audio
encoders to set the MTU or so, and then configure that on the pool. And also
resize output buffers accordingly if less than that was written.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list