[Bug 795395] iOS GstPlay app: Seekbar slider not reacting

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795395

--- Comment #1 from Stephan Hesse <tchakabam at gmail.com> ---
Trying to send an attachment to Bugzilla failed with timeout for me
unfortunately. 

We have a patch that fixes the issue. We hope it does not have any side-effect.
It seems that there was a rendering hack in place for some reason, but we don't
see any need for it currently.

Posting our patch proposal here:

From: Stephan Hesse <tchakabam at gmail.com>
Date: Fri, 20 Apr 2018 11:22:37 +0200
Subject: [PATCH] iOS GstPlay: fix seeking slider behavior

---
 playback/player/ios/GstPlay/VideoViewController.m | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/playback/player/ios/GstPlay/VideoViewController.m
b/playback/player/ios/GstPlay/VideoViewController.m
index 079fcde..767426f 100644
--- a/playback/player/ios/GstPlay/VideoViewController.m
+++ b/playback/player/ios/GstPlay/VideoViewController.m
@@ -74,6 +74,9 @@ - (void)viewDidLoad

     is_local_media = [uri hasPrefix:@"file://"];
     is_playing_desired = NO;
+    time_slider.value = 0;
+    time_slider.minimumValue = 0;
+    time_slider.maximumValue = 0;
 }

 - (void)viewDidDisappear:(BOOL)animated
@@ -152,7 +155,9 @@ - (void)viewDidLayoutSubviews
         video_height_constraint.constant = view_height;
     }

-    time_slider.frame = CGRectMake(time_slider.frame.origin.x,
time_slider.frame.origin.y, toolbar.frame.size.width -
time_slider.frame.origin.x - 8, time_slider.frame.size.height);
+    // Breaks Slider display/usage. FIXME: What was this for initially?
+    // time_slider.frame = CGRectMake(time_slider.frame.origin.x,
time_slider.frame.origin.y, toolbar.frame.size.width -
time_slider.frame.origin.x - 8, time_slider.frame.size.height);
+
 }

 static void video_dimensions_changed (GstPlayer * unused, gint width, gint
height, VideoViewController * self)
@@ -198,6 +203,7 @@ static void duration_changed (GstPlayer * unused,
GstClockTime duration, VideoVi

 -(void) durationChanged:(NSInteger)duration
 {
+    time_slider.minimumValue = 0;
     time_slider.maximumValue = duration;
     [self updateTimeWidget];
 }
-- 
2.15.1 (Apple Git-101)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.