[Bug 795415] jpegenc: Disallow upstream renegotiation if downstream doesn't support it

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795415

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Comment on attachment 371173 [details] [review]
> jpegenc: Disallow upstream renegotiation if downstream doesn't support it
> 
> Why is this necessary at all? The default getcaps should query downstream
> and then convert the caps accordingly (with the proxy getcaps function).
> This should have the same effect.

The format is not availaible downstream so the default implementation uses the
first specified, which might lead to the not negotiated error.

(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 371173 [details] [review]:
> 
> ::: ext/jpeg/gstjpegenc.c
> @@ +581,3 @@
> +
> +    downstream_caps = gst_pad_peer_query_caps (enc->srcpad, NULL);
> +    if (gst_caps_is_fixed (downstream_caps)) {
> 
> image/jpeg are also fixed caps :)

That doesn't sound possible to have upstream fixed and downstream fixed without
all the required fields.

> @@ +587,3 @@
> +
> +      if (filter)
> +        ret = gst_caps_intersect (input_caps, filter);
> 
> gst_caps_intersect_full(filter, input_caps, GST_CAPS_INTERSECT_FIRST)

Fixed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.