[Bug 794998] omxvideoenc: restore OMX default target-bitrate if requested by user

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794998

Guillaume Desmottes <gdesmott at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.15.1

--- Comment #11 from Guillaume Desmottes <gdesmott at gnome.org> ---
Thanks, fixed and merged to master.

commit 72cb1943da2d28b8ec87d75d0821f6e480d2ef4d (HEAD -> master, origin/master,
origin/HEAD)
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Thu Mar 29 16:42:40 2018 +0200

    omxvideoenc: restore OMX default target-bitrate if requested by user

    0xffffffff is the magic number in gst-omx meaning 'the default value
    defined in OMX'. This works fine with OMX parameters which are only set
    once when starting the component but not with configs which can be
    changed while PLAYING.
    Save the actual OMX default bitrate so we can restore it later if user
    sets back 0xffffffff on the property.

    Added GST_OMX_PROP_OMX_DEFAULT so we stop hardcoding magic numbers
    everywhere.

    https://bugzilla.gnome.org/show_bug.cgi?id=794998

commit 542faf0f367a0dd06bf83bf124572a28b46dc04c
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Thu Mar 29 11:36:00 2018 +0200

    omxvideoenc: use gst_omx_video_enc_set_bitrate() when setting bitrate in
set_format

    We weren't using the usual pattern when re-setting the bitrate:
    - get parameters from OMX
    - update only the fields different from 0xffffffff (OMX defaults)
    - set parameters

    Also added a comment explaining why we re-set this param.

    https://bugzilla.gnome.org/show_bug.cgi?id=794998

commit 256f77b621777f7c961222059bf9cee37f22bd14
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Thu Mar 29 11:26:04 2018 +0200

    omxvideoenc: factor out gst_omx_video_enc_set_bitrate()

    No semantic change, I'm about to re-use this function in set_format().

    https://bugzilla.gnome.org/show_bug.cgi?id=794998

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.