[Bug 795397] audiomixer caps negotiation broken

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Apr 23 14:37:50 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795397

--- Comment #5 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Created attachment 371277
  --> https://bugzilla.gnome.org/attachment.cgi?id=371277&action=edit
audioaggregator: fix filtered getcaps

In the situation described in
https://bugzilla.gnome.org/show_bug.cgi?id=795397,

downstream_caps consists of two structures, the first with
the preferred rate, if at all possible (44100), the second
containing the full range of allowed rates, as audioresample
correctly tries to negotiate passthrough caps.

As audioaggregator cannot perform rate conversion, it wants
to return a fixated rate in its getcaps implementation,
however it previously directly used the first structure in
the caps allowed downstream, without taking the filter into
consideration, to determine the rate to fixate to.

With this, we first intersect our downstream caps with the
filter, in order not to fixate to an unsupported rate.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list