[Bug 795021] Reduce amount of memory allocations when payloading fixed-size audio buffers

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Apr 23 15:20:02 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795021

--- Comment #20 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #19)
> Ok then we just go into the normal code path again. Can you add a comment
> about that somewhere in the code?

will do :)

> 
> Also I'm not entirely sure this is correct. In theory upstream could take
> one of our buffers, have the single reference and add memories or resize it
> or whatever. But that does not change buffer->pool, does it?

It will not change it no. We could check if the memory tag is set, and then
compare the buffer sizes with our expectations maybe ?

> I guess this answers my previous question :)

I think it does yes :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list