[Bug 795139] Various patches on rtpsession

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795139

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370741|none                        |reviewed
             status|                            |

--- Comment #24 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 370741:
 --> (https://bugzilla.gnome.org/review?bug=795139&attachment=370741)

Can you add slightly more descriptive signal names? Otherwise looks good

::: gst/rtpmanager/rtpsession.c
@@ +246,3 @@
+   */
+  rtp_session_signals[SIGNAL_ON_SSRC_PSE] =
+      g_signal_new ("on-ssrc-pse", G_TYPE_FROM_CLASS (klass),

maybe on-ssrc-profile-specific-ext ? A couple extra characters are not that
expensive!

@@ +309,3 @@
+   */
+  rtp_session_signals[SIGNAL_ON_CREATING_SRRR] =
+      g_signal_new ("on-creating-srrr", G_TYPE_FROM_CLASS (klass),

can we do on-creating-sr-rr? I couldn't guess was srrr was!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.