[Bug 795391] vaapi: problems when playing with glimagesink with egl

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795391

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371315|none                        |reviewed
             status|                            |

--- Comment #11 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 371315:
 --> (https://bugzilla.gnome.org/review?bug=795391&attachment=371315)

::: gst-libs/gst/vaapi/gstvaapidisplay_egl.c
@@ +51,3 @@
   guint display_type;
   guint gles_version;
+  gboolean is_native;

why not just add gpointer egl_display instead of juggling with different
semantics in one single variable?

@@ +117,3 @@
 #endif
 #if USE_WAYLAND
+    if (!native_vaapi_display)

we could use params->display_type to choose what vaapi display instantiates,
besides the compilation dependencies

::: gst/vaapi/gstvaapipluginutil.c
@@ +211,3 @@
+      GstGLDisplayEGL *egl_display;
+
+      egl_display = gst_gl_display_egl_from_gl_display (gl_display);

why not call here too gst_gl_display_get_handle() thus you could get a common
guintptr variable, which could be null by default.

@@ +259,3 @@
+
+  if (gl_display)
+    gst_object_unref (gl_display);

I don't see the reason for this unref since gl_display was unrefed already.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.