[Bug 795391] vaapi: problems when playing with glimagesink with egl

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795391

--- Comment #14 from Hyunjun Ko <zzoon at igalia.com> ---
Review of attachment 371315:
 --> (https://bugzilla.gnome.org/review?bug=795391&attachment=371315)

::: gst-libs/gst/vaapi/gstvaapidisplay_egl.c
@@ +51,3 @@
   guint display_type;
   guint gles_version;
+  gboolean is_native;

Well, that's what I thought for a while.
Adding another gpointer is fine to me, too.

@@ +118,3 @@
 #if USE_WAYLAND
+    if (!native_vaapi_display)
+      native_vaapi_display = gst_vaapi_display_wayland_new (NULL);

This is not about this patch, isn't it?
Anyway it still needs "#if USE_WAYLAND" since the header is included under the
macro.

::: gst/vaapi/gstvaapipluginutil.c
@@ +211,3 @@
+      GstGLDisplayEGL *egl_display;
+
+      egl_display = gst_gl_display_egl_from_gl_display (gl_display);

Ah i didn't realize it. Thanks.

@@ +259,3 @@
+
+  if (gl_display)
+    gst_object_unref (gl_display);

That unref of gl_display is removed in this patch :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.