[Bug 795327] "rfbsrc" linked to "videorate" causes error "invalid buffer size 4096 < 4196352"

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795327

Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.15.1

--- Comment #3 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
commit ede8b1c8ce90c18be548d9ec88ba8c53d14b5043 (HEAD -> master, origin/master,
origin/HEAD)
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Wed Apr 25 15:05:38 2018 -0400

    rfbsrc: Fix decide_allocation to support NULL pool

    We were assuming that NULL pool meant that downstream didn't reply.
    Update the pool index 0 instead of adding at the end. Otherwise we ended
    up letting basesrc decide, which would pick the blocksize as a size
    (4096) instead of the image size.

    https://bugzilla.gnome.org/show_bug.cgi?id=795327

This is good candidate for backport, let me know if that would be useful for
you. I've also added support for applevncserver while at it.


commit 5d1efe7f556f4a47a2a80d19bc73ea1875fbcc73
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Wed Apr 25 13:36:01 2018 -0400

    rfbsrc: Fix support for applevncserver

    This server uses an unknown 003.889 protocol version. This patch fixes
    the version validation in order to simply fallback to 3.3 as suggested
    by the spec.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.