[Bug 795391] vaapi: problems when playing with glimagesink with egl

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795391

--- Comment #28 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Hyunjun Ko from comment #27)
> (In reply to Víctor Manuel Jáquez Leal from comment #23)
> > Review of attachment 371315 [details] [review] [review]:
> > 
> > By the way, this patch will need to be rebased after bug 793643 is merged
> > 
> > ::: gst-libs/gst/vaapi/gstvaapidisplay_egl.c
> > @@ +118,3 @@
> >  #if USE_WAYLAND
> > +    if (!native_vaapi_display)
> > +      native_vaapi_display = gst_vaapi_display_wayland_new (NULL);
> > 
> > yes, we still need the macro. Just we could create efficiently the internal
> > display by identifying the environment instead of try-and-error
> 
> I see, but in case of GST_VAAPI_DISPLAY_TYPE_EGL, we have to do
> try-and-error.

Agree. That's the case with attachment 371465

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.